Closed
Conversation
Collaborator
|
Thank you very much for this PR @njelich ! My personal opinion is that this project shoudn't require a rust-toolchain.toml and eat-up gigabytes of rust binaries just to start building, even if that means that sometimes it breaks when the latest nightly breaks. I like the CI/CD integration though, I'll enable the feature for the repo. I'll ask for some more feedback in my team and come back to you. |
louismerlin
requested changes
Feb 8, 2024
| rustup target add wasm32-unknown-unknown | ||
| - name: Build fuzzer | ||
| run: | | ||
| cargo afl config --build --force |
Collaborator
There was a problem hiding this comment.
This won't work in GitHub Actions. You can use these flags instead:
| - uses: actions/checkout@v3 | ||
| - name: Setup dependencies | ||
| run: | | ||
| cargo install ziggy cargo-afl honggfuzz grcov |
Collaborator
There was a problem hiding this comment.
No need for grcov in this situation.
Collaborator
|
Fixed in #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stdsimd unstable feature was removed from rust, some packages updated with that in mind. Many are broken.
rust-lang/rust#48556
I am adding a CI to catch issues in the future, as well as a rust-toolchain.toml file to lock the toolchain to a good version in the future.
With the current toolchain setup, all thats left for everything to get back into working order is for Ahash to accept a patch for an older version that is still used by some dependencies of this project.
tkaitchuck/aHash#201