add vertical logo#19
Open
Adimote wants to merge 4 commits into
Open
Conversation
raccube
approved these changes
Sep 16, 2020
raccube
left a comment
raccube
left a comment
Member
There was a problem hiding this comment.
Might be a good idea to minify the svg but otherwise 👍
PeterJCLaw
previously requested changes
Sep 16, 2020
PeterJCLaw
left a comment
PeterJCLaw
left a comment
Member
There was a problem hiding this comment.
Please do not merge this. It is intentional that there is no vertical logo in the repo. Please see the house style guidelines for use of the logo: https://studentrobotics.org/style/.
Member
|
This is the logo we use on the front of the t-shirts so I would argue it's already part of our style (so the style guide should be updated to reflect this) |
Member
|
We should fill the blue logo with white |
PeterJCLaw
dismissed
their stale review
house style updated to allow for vertical logo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.