-
Notifications
You must be signed in to change notification settings - Fork 4
🎨 Palette: Add daysUntilEOL property #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Palette: Add daysUntilEOL property #797
Conversation
- Added `daysUntilEOL` to `NodeVersion` interface and implementation. - Updated documentation in `Readme.md` to include `eolDate` and `daysUntilEOL`. - Added tests for `daysUntilEOL` covering future, past, and unknown EOL dates. - Improved DX by providing a pre-calculated value for EOL countdowns.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 46 49 +3
Branches 16 19 +3
=========================================
+ Hits 46 49 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #826 - closing duplicate bot-generated PR |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Palette added
daysUntilEOLto theNodeVersionobject. This micro-UX improvement (DX) allows developers to easily check how many days are left until a Node.js version reaches End-of-Life, without implementing date math themselves. It returns a number (days) or undefined. Documentation and tests were updated accordingly.PR created automatically by Jules for task 7714978807207570716 started by @srod
Summary by cubic
Added daysUntilEOL to NodeVersion to return the number of days until the version’s EOL, making it easy to warn or schedule upgrades without date math.
It can be negative if EOL has passed, or undefined if unknown; documentation and tests updated.
Written for commit 5984151. Summary will update on new commits.