π‘οΈ Sentinel: Enforce MAX_VERSION_LENGTH to prevent DoS #802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘οΈ Sentinel: [MEDIUM] Fix input length limits (DoS risk)
π¨ Severity: MEDIUM
π‘ Vulnerability: Excessively long version strings could cause performance issues or memory exhaustion during parsing/comparison.
π― Impact: Denial of Service (DoS) if user input is uncontrolled.
π§ Fix: Enforced a
MAX_VERSION_LENGTHof 256 characters. Inputs exceeding this limit immediately returnNaN.β Verification: Added a test case in
src/security.test.tswith a 300+ character string. Verified that comparisons returnfalse(fail-closed).PR created automatically by Jules for task 16523819671176676093 started by @srod
Summary by cubic
Enforces a 256-character max length for version strings to prevent DoS from oversized inputs. Strings over the limit return NaN so all boolean checks fail closed.
Written for commit 93256d6. Summary will update on new commits.