🛡️ Sentinel: [HIGH] Fix DoS vulnerability in version comparison #805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
MAX_VERSION_LENGTHconstant (256) and a check incompareTofunction insrc/index.ts. This limits the length of version strings processed, preventing potential Denial of Service (DoS) attacks via CPU or memory exhaustion from extremely long strings. Verified with tests.PR created automatically by Jules for task 5783055142362756436 started by @srod
Summary by cubic
Fixes a DoS vulnerability in version comparison by capping version string length. compareTo now rejects inputs longer than 256 characters and returns NaN to fail closed.
Written for commit 38d314e. Summary will update on new commits.