-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add toJSON support for NodeVersion #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a `toJSON` method to the `NodeVersion` object and interface. This enables clean serialization via `JSON.stringify(version)`, returning a plain object with data properties (original, major, isLTS, etc.) while excluding methods. This improves Developer Experience (DX) when logging or inspecting the version object.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 46 48 +2
Branches 16 16
=========================================
+ Hits 46 48 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #826 - closing duplicate bot-generated PR |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
🎨 Palette: Added
toJSONsupport toNodeVersion💡 What: Added a
toJSONmethod to theNodeVersioninterface and implementation.🎯 Why: To allow
JSON.stringify(version)to return a clean, data-only object without methods, improving the developer experience when logging or debugging.📸 Before:
JSON.stringify(version)would be empty or messy depending on environment/serialization.📸 After:
JSON.stringify(version)returns{ original: "v20.0.0", major: "20", ... }.♿ Accessibility: N/A (Backend library) - Improves DX.
PR created automatically by Jules for task 4344880314678674471 started by @srod
Summary by cubic
Added toJSON to NodeVersion so JSON.stringify(version) returns a plain, data-only object. This makes logs and debugging clearer.
Written for commit bd1e2de. Summary will update on new commits.