β‘ Bolt: Optimize version comparison performance #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What: Optimized
compareTofunction insrc/index.ts.π― Why: Version comparison is a hot path. The previous implementation used regex and string splitting which are relatively expensive.
π Impact: ~12x speedup in
version.isAtLeastbenchmarks.π¬ Measurement: Verified with
bench.ts(created and deleted during process) showing ops/sec increase from ~930k to ~11M. Validated correctness withsrc/index.test.tsandsrc/security.test.ts.PR created automatically by Jules for task 12037906949651648021 started by @srod
Summary by cubic
Optimized version comparison by rewriting compareTo in src/index.ts to use a single-pass parser instead of regex and splits. This delivers ~12x faster version.isAtLeast with no behavior changes.
Written for commit 2aa0000. Summary will update on new commits.