fix: Improve lrclib lyrics fetching#441
Open
Kreedyy wants to merge 1 commit into
Open
Conversation
…searching, only searching for song name + artist is more reliable because of inconsistencies with tagging music a a a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using /api/get requires all parameters to be very exact for it to find any results but songs aren't always tagged 100% the same as they are stored on lrclib, I myself go through the effort of tagging my music as best I can but Navidrome sets the tag of albumless songs to [Unknow Album] for example, which will never find a match on lrclib. It's better to use /api/search with only the q param to search for lyrics more loosely only using the song name + artist name and then filtering those results out based on album or duration.