Resolve generated kick_off.py paths relative to script directory#74
Merged
RogerJanusiak merged 1 commit intoMay 14, 2026
Merged
Conversation
014d2fa to
6f22d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
kick_off.pyscripts resolve the capabilities file and transformer command relative to the script file itself so the generated runner works when executed from another working directory or after being copied./generated/...references that were missed by the previous WSL script fix.Description
kick_off.pytemplate inservicex_local/science_images.pyto computescript_dirfrom__file__, loadtransformer_capabilities.jsonfromscript_dir, and normalizeinfo["command"]so/generated/...and relative paths become script-relative while leaving other absolute paths unchanged.script_dir+ command-normalization logic to the WSLkick_off.pytemplate embedded inWSL2ScienceImage.transformso the WSL-generated runner also resolves paths correctly.python "$script_dir/kick_off.py"instead of referring to the old generated-directory path.wsl_generated_files_dirlocal variable inWSL2ScienceImage.transformafter switching to script-relative resolution.Testing
python -m black --check servicex_local/science_images.py, which passed.python -m flake8 servicex_local/science_images.py, which failed due to existingE501line-length violations in the file and not caused by these changes.pytest, which failed with pre-existingTransformStatusvalidation errors in adaptor/deliver tests and are unrelated to thekick_off.pypath fixes.Codex Task