Skip to content

isPure + Match Arm Elimination#161

Open
EmilySillars wants to merge 13 commits intomainfrom
inliner-nits
Open

isPure + Match Arm Elimination#161
EmilySillars wants to merge 13 commits intomainfrom
inliner-nits

Conversation

@EmilySillars
Copy link
Copy Markdown
Contributor

@EmilySillars EmilySillars commented May 12, 2023 •
edited
Loading

  • adds a an isPure predicate to the preinline phase to account for side effects when inlining
  • fixes a bug related to unintentional inlining of scrutinees, + added intentional inlining of scrutinees
  • adds match arm elimination
  • adds regression tests for each of the above 3 features

efric and others added 11 commits April 19, 2023 12:03
@efric
nits: add just never case to stop unintended inlining of prims in mat…
df3d23f 
…ch statements. however, adding just never case causes some test cases to fail
@efric
inliner: fix failing test cases after Just Never case
337626c 
A Just Never Case was added for when we don't want to ever inline a
binder. The change made some unit tests fail. This commit fixes that
problem by allowing inlining RHS of binder. (This can probably be made
cleaner later).

Also add missing test cases and delete accidentally commited files
@EmilySillars
fix inlining bug from ex 7
292f95a
@efric
inliner: add some extra comments explanining behavior of simplify step
24462bd
@efric
prepare for match arm elimination integration
8b5c16f
@efric
match arm elimination: handle case for literals
ba565eb
@efric
initial working match arm elimination
41f46cd
@efric
integrate isPure check for inliner
1214808
@EmilySillars
clean up code
a8de5c9
@EmilySillars
resolve merge conflicts
8b25a7b
@EmilySillars
fix more merge conflicts
8bb2772
EmilySillars
EmilySillars commented May 20, 2023
View reviewed changes
Comment thread regression-tests/tests/inlining-ex-3.ssl
Comment thread regression-tests/tests/inlining-ex-14.ssl.failing Outdated
Comment thread regression-tests/tests/inlining-ex-9.ssl Outdated
Comment thread src/IR/Simplify.hs Outdated
Comment thread src/IR/Simplify.hs Outdated
Comment thread src/IR/Simplify.hs Outdated
Comment thread src/IR/Simplify.hs
@EmilySillars
Copy link
Copy Markdown
Contributor Author

EmilySillars commented May 20, 2023

This PR is ready to merge!

  • adds a checkPure condition to the preinline phase to account for side effects when inlining
  • fixes a bug related to unintentional inlining of scrutinees, + added intentional inlining of scrutinees
  • adds match arm elimination
  • adds regression tests for each of the above 3 features
  • since the simplifier does not currently support mutual recursion, I added a check for recursive let bindings. Upon finding a let expression with a list of more than one binding, the simplifier passes along the program unmodified. I did this because I thought ignoring programs that potentially have mutually recursive bindings seemed like the easiest/simplest patch. @j-hui If you'd prefer I rename the mutual recursion regression tests to .failing instead, or some other solution, LMK.

@EmilySillars EmilySillars requested a review from j-hui May 20, 2023 20:44
@EmilySillars EmilySillars marked this pull request as ready for review May 20, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-hui j-hui Awaiting requested review from j-hui

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilySillars @efric