Skip to content

Memory/Variable Block Size#339

Closed
ssoelvsten wants to merge 2 commits intomainfrom
memory/variable_block_size
Closed

Memory/Variable Block Size#339
ssoelvsten wants to merge 2 commits intomainfrom
memory/variable_block_size

Conversation

@ssoelvsten
Copy link
Copy Markdown
Owner

@ssoelvsten ssoelvsten commented May 24, 2022

Closes #160 .

This cannot be merged before any fix to thomasmoelhave/tpie#250 is made, such as the pull request in thomasmoelhave/tpie#254 .

@ssoelvsten ssoelvsten self-assigned this May 24, 2022
@ssoelvsten ssoelvsten added the ✨ optimisation It's all about speed / space label May 24, 2022
@ssoelvsten ssoelvsten marked this pull request as draft May 24, 2022 14:32
@github-actions
Copy link
Copy Markdown

Benchmark Report 🟡

origin/memory/variable_block_size is a regression of 1.46% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/memory/variable_block_size
0.29 0.29
Raw Data

Running times (s) for 9-Queens:

origin/main origin/memory/variable_block_size
0.29 0.29
0.29 0.29
0.29 0.29
0.29 0.30
0.29 0.30
0.29 0.34
0.29 0.29
0.30 0.29
0.30 0.30
0.29 0.29
0.29 0.30
0.29 0.29
0.29 0.30
0.29 0.29
0.29 0.30
0.29 0.30

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.391%. Comparing base (55988c5) to head (61cec60).
⚠️ Report is 1203 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #339       +/-   ##
=============================================
+ Coverage   97.384%   97.391%   +0.007%     
=============================================
  Files           58        58               
  Lines         3287      3296        +9     
=============================================
+ Hits          3201      3210        +9     
  Misses          86        86               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Repository owner deleted a comment from github-actions Bot Jun 5, 2022
Repository owner deleted a comment from github-actions Bot Jun 5, 2022
@ssoelvsten ssoelvsten force-pushed the main branch 14 times, most recently from dfbfdbf to 2904d93 Compare July 29, 2022 09:01
@ssoelvsten
Copy link
Copy Markdown
Owner Author

The refactor in #397 will add a giant mess of conflicts. It is better to just wait until thomasmoelhave/tpie#254 is merged and then give it another go.

@ssoelvsten ssoelvsten closed this Nov 30, 2022
@ssoelvsten ssoelvsten deleted the memory/variable_block_size branch November 30, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ optimisation It's all about speed / space

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for larger block sizes

2 participants