Fix Maya SDK resolution and clean up CMake presets - #4
Merged
Conversation
- cmake/FindMaya.cmake: prefer the cached SDK matching MAYA_VERSION before scanning the other cached SDKs (newest-first) as a fallback, so a Maya-2027 build never resolves the 2026 SDK just because it was cached earlier. - CMakePresets.json: drop the unused ci preset (configure + build) and the redundant BUILD_NATIVE_MODULE=ON override (the option already defaults to ON), and add explicit Debug/Release configuration to the build presets. - docs/CPPDevelopment.md: replace the removed ci-preset instructions with the maya2026-release -DBUILD_TESTS=ON flow. - CHANGELOG.md: note the SDK-resolution fix and the preset cleanup. Extracted from feature/physics-system (PR #3) so the build-system fixes can be reviewed independently of the physics feature.
sstarosz
added a commit
that referenced
this pull request
Aug 9, 2026
- vcpkg.json: add Bullet 3.25 (float precision) as the first C/C++ dependency. - CMakeLists.txt: fail with clear instructions when no CMake toolchain is configured, then resolve Bullet via find_package(Bullet CONFIG REQUIRED). - CMakePresets.json: add the hidden with-vcpkg preset that activates the vcpkg toolchain from \, and make all maya* presets inherit it. - .github/workflows: set up vcpkg (lukka/run-vcpkg) in pr-checks and release. - .gitignore: ignore third_party/ and vcpkg_installed/. - docs/CPPDevelopment.md: document vcpkg setup + troubleshooting. - README.md: list vcpkg as a prerequisite and note auto-install of deps. - CHANGELOG.md: note vcpkg dependency management under [Unreleased]. - tests/CMakeLists.txt: drop the stale 'Re-enable the CI preset (ci)' comment (the ci preset was removed in PR #4). Part of the feature/physics-system (PR #3) split — stacked on PR #4 (fix/cmake-build-fixes).
sstarosz
added a commit
that referenced
this pull request
Aug 9, 2026
- vcpkg.json: add Bullet 3.25 (float precision) as the first C/C++ dependency. - CMakeLists.txt: fail with clear instructions when no CMake toolchain is configured, then resolve Bullet via find_package(Bullet CONFIG REQUIRED). - CMakePresets.json: add the hidden with-vcpkg preset that activates the vcpkg toolchain from \, and make all maya* presets inherit it. - .github/workflows: set up vcpkg (lukka/run-vcpkg) in pr-checks and release. - .gitignore: ignore third_party/ and vcpkg_installed/. - docs/CPPDevelopment.md: document vcpkg setup + troubleshooting. - README.md: list vcpkg as a prerequisite and note auto-install of deps. - CHANGELOG.md: note vcpkg dependency management under [Unreleased]. - tests/CMakeLists.txt: drop the stale 'Re-enable the CI preset (ci)' comment (the ci preset was removed in PR #4). Part of the feature/physics-system (PR #3) split — stacked on PR #4 (fix/cmake-build-fixes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, self-contained build-system fixes.
Changes
cmake/FindMaya.cmakeFix SDK resolution: prefer the cached SDK matching
MAYA_VERSIONfirst, then scan the remaining cached SDKs newest-first as a fallback. Previously a Maya-2027 build could resolve the 2026 SDK just because it was cached earlier.CMakePresets.jsonciconfigure + build preset (no workflow, script, or doc depends on it — CI uses themaya*presets).BUILD_NATIVE_MODULE=ONoverride from thebasepreset (the option already defaults toON).Debug/Releaseconfigurationto themaya*build presets.docs/CPPDevelopment.mdReplace the removed
ci-preset instructions with themaya2026-release -DBUILD_TESTS=ONflow in the two unit-test sections.CHANGELOG.mdNote the SDK-resolution fix and the preset cleanup under
[Unreleased].