Add support for multiple custom styles, separated by a space#136
Open
js-seo wants to merge 1 commit intosstur:masterfrom
Open
Add support for multiple custom styles, separated by a space#136js-seo wants to merge 1 commit intosstur:masterfrom
js-seo wants to merge 1 commit intosstur:masterfrom
Conversation
|
+1 |
|
@sstur Why has not this solution been implemented yet? I would like to be able to use it without changing my node_modules. Review please |
EmanuelGenially
approved these changes
Apr 24, 2018
preetriti
reviewed
May 18, 2018
preetriti
left a comment
There was a problem hiding this comment.
There is another way to do this with lesser changes.
In line: 344 just use style.union(customInline.styles)
Now the Style in inlineCreators should be changed from string -> string[].
This way it removes the condition that styles should be separated with ' '. The code can be agnostic to that.
|
It doesn't work with rgb colours because split find spaces in colours - rgb(255, 120, 0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you do this,
now each inline element has overlapping four styles.