Majority fork - #20
Open
nkryuchkov wants to merge 4 commits into
Open
Conversation
nkryuchkov
marked this pull request as ready for review
October 9, 2025 12:54
nkryuchkov
force-pushed
the
majority-fork
branch
from
October 15, 2025 10:13
2cae2d9 to
d50a277
Compare
# Conflicts: # scenarios/main.yaml
y0sher
previously approved these changes
Oct 19, 2025
y0sher
left a comment
y0sher
left a comment
Contributor
There was a problem hiding this comment.
This looks good and I've tested it manually, but I think it should have a script that actually runs a test to check it works. It can be added in separate PR but it should include:
- Check that some nodes are on a fork
- Check that SSV stops voting.
it also misses the next part we want to prove, that SSV can join the minority once majority has fixed their bugs and not get slashed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducing the holesky bug and testing it with ssvlabs/ssv#2358