Suggested fixes for review feedback on #2843

[iurii-ssv]

Suggested resolutions for the inline review feedback on #2843. Each commit-included change matches one inline comment in that review — merge as-is, cherry-pick, or close if you'd rather address differently.

Changes

• Tighten ssv_p2p_pubsub_messages_received_total description so an operator reading the metric registry can immediately tell it is the pre-validation counterpart of ssv_p2p_messages_in_total.
• Add a brief comment on recordPubsubMessageReceived noting it is called from the validator wrapper before the inner validator runs, so all outcomes (accept/ignore/reject/timeout) are counted — useful context for the next reader.
• Rename test loop variable that shadowed the imported go.opentelemetry.io/otel/sdk/metric package (lint-only nit).

Not included

The cross-counter attribute-key fragmentation (ssv.p2p.pubsub.topic vs ssv.p2p.message.topic vs ssv.p2p.topic.name) is left for you to decide on — that one is a design call rather than a mechanical fix.

Test plan

• go build ./network/topics/...
• go test -run TestRecordPubsubMessageReceived ./network/topics/ -count=1

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.3%. Comparing base (b88c35e) to head (b183fd7).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Greptile Summary

Three targeted follow-up fixes after review of #2843: a tightened metric description for ssv.p2p.pubsub.messages.received that now cross-references ssv_p2p_messages_in_total, a doc comment on recordPubsubMessageReceived noting its pre-validation call site, and a loop-variable rename in the test to stop shadowing the imported metric package.

• The metric description now explicitly labels the counter as pre-validation and points readers to the post-validation companion counter, making the two metrics easier to correlate in Prometheus/Grafana.
• The variable rename in the test (metric → m) eliminates a lint warning without changing test logic or coverage.

Confidence Score: 5/5

All three changes are non-functional: a metric description update, a doc comment, and a lint-only variable rename. No logic, data flow, or API surface is altered.

Every change in this PR is cosmetic or documentation-level. The metric description cross-reference uses the correct Prometheus-rendered name (ssv_p2p_messages_in_total from OTel name ssv.p2p.messages.in). The new doc comment accurately reflects the call site. The variable rename correctly avoids shadowing the imported package without touching any test assertions.

No files require special attention.

Important Files Changed

Filename	Overview
network/topics/observability.go	Expanded metric description to cross-reference ssv_p2p_messages_in_total; added doc comment on recordPubsubMessageReceived clarifying pre-validation call site — no logic changes
network/topics/observability_test.go	Renamed loop variable metric → m to fix shadowing of the imported go.opentelemetry.io/otel/sdk/metric package; purely mechanical lint fix with no semantic change

Sequence Diagram

sequenceDiagram
    participant libp2p
    participant ValidatorWrapper
    participant recordPubsubMessageReceived
    participant pubsubMessagesReceivedCounter
    participant InnerSSVValidator
    participant inboundMessageCounter

    libp2p->>ValidatorWrapper: deliver message
    ValidatorWrapper->>recordPubsubMessageReceived: call (pre-validation)
    recordPubsubMessageReceived->>pubsubMessagesReceivedCounter: +1 (ssv_p2p_pubsub_messages_received_total)
    ValidatorWrapper->>InnerSSVValidator: run SSV validation
    alt accept
        InnerSSVValidator->>inboundMessageCounter: +1 (ssv_p2p_messages_in_total)
    else ignore / reject / timeout
        InnerSSVValidator-->>ValidatorWrapper: drop
    end

Loading

_{Reviews (1): Last reviewed commit: "network/topics: clarify pubsub-received ..." | Re-trigger Greptile}

[momosh-ssv]

It's dangerous to go to production alone! Take this. 🛡️✅