eth/executionclient: widen the flaky tests' context budgets (#2970, convergence) - #2977
eth/executionclient: widen the flaky tests' context budgets (#2970, convergence)#2977momosh-ssv wants to merge 2 commits into
Conversation
TestStreamLogs/successfully_streams_logs and TestSimSSV shared a single 5s context serving both as the production streaming context and the tests' own poll deadline - on loaded CI runners scheduling jitter alone blew the budget while everything was progressing (streamedLogsCount: 25 of 30 at expiry). Both wait loops already react to their condition immediately, so only the CI-safety margin changes (5s -> 30s at the two call sites); the fast path is unaffected and other tests keep their budgets. Refs #2970 (these two were failing essentially every CI run today, blocking unrelated PRs).
Greptile SummaryWidens the context deadlines in two flaky execution-client integration tests from 5 seconds to 30 seconds while preserving fast-path polling and event-driven completion.
Confidence Score: 5/5The PR appears safe to merge because it only widens test deadlines without changing production behavior or successful test completion paths. Both affected tests still complete as soon as their polling or event conditions succeed, while the longer contexts reduce failures caused by scheduling delays.
|
| Filename | Overview |
|---|---|
| eth/executionclient/execution_client_test.go | The two test-only timeout increases leave successful execution unchanged and provide additional time for asynchronous simulator event processing on loaded CI runners. |
Reviews (1): Last reviewed commit: "eth/executionclient: widen the flaky tes..." | Re-trigger Greptile
The first pass widened only the two named flaky tests, but the same loaded-runner conditions promptly failed TestFetchHistoricalLogs on its own 5s budget (died at 8.3s). Every setupTestEnv budget in the package is condition-driven waiting under the hood, so widen them all to 30s - the fast path is unaffected.
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Cherry-pick of #2976 onto
integration/boole-convergence— todayTestStreamLogs/TestSimSSVfailed on essentially every CI run of the convergence-based PRs (#2971 needed four attempts), and a fix onstagedoesn't reach their CI. Same two one-line test-only budget bumps (5s → 30s); the two branches' copies of the file are identical, so the eventual #2941 merge dedups cleanly. See #2976 for the root-cause analysis.