fix(remote): preserve local file tab order - #13233
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughMirrored host tab ordering now merges host-defined positions with the current local group order. Local non-mirrored tabs retain their positions. Invalid and duplicate IDs are removed, and remaining host tabs are appended. Group construction uses the merged order. Tests cover local tab preservation and stale mirrored tab filtering. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 898f8b9a-c88f-45d6-81a1-9a6bd4d9df4a
📒 Files selected for processing (2)
src/renderer/src/runtime/web-session-tabs-sync.test.tssrc/renderer/src/runtime/web-session-tabs-sync.ts
d7fbcf5 to
3f71a3f
Compare
Sync update (
|
Description
Remote file tabs opened from terminal output now preserve their local file-tab positions when the remote tab snapshot is reconciled.
The sync layer stops treating host-owned remote layout data as authoritative for local file tabs that were opened on the client.
Focused fix
Preserves
Evidence
pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/runtime/web-session-tabs-sync.test.tsUser-regression-tradeoffs
Fixes #13055