Tighten up some definitions#19
Merged
Merged
Conversation
Explicitly define how nadir and sub-satellite point are defined, for anyone unfamiliar with the terms Consistently use the term "scene" rather than "target". To me, "target" could be ambiguous - is it the location that was imaged, or the location that was *desired* to be imaged? Those may be different if the satellite has a boresight misalignment or otherwise failed to point at. (Admittedly, for defining ONA/azimuth/... at a whole scene, that target vs. scene difference is pretty negligible) I'd also be interested in a more concrete definition of scene center, but I am unsure as to whether the definition is: * The location imaged by the central pixel (for a frame imager, anyway) * A centroid derived from pixels containing data * A centroid derived from a bounding box or bounding polygon * other!
DFEvans
force-pushed
the
patch/definitions
branch
from
129b6ba to
c0580cd
Compare
gadomski
approved these changes
May 29, 2026
Member
There was a problem hiding this comment.
Makes sense to me ... I did a quick search of the document and got no hits for "target", so 👍🏼 to consolidating the language.
I'm requesting review from @matthewhanson as extension owner, as well.
I'd also be interested in a more concrete definition of scene center
I won't weigh into this question, but if you'd like to open an issue to track the question, that'd be great!
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly define how nadir and sub-satellite point are defined, for anyone unfamiliar with the terms
Consistently use the term "scene" rather than "target". To me, "target" could be ambiguous - is it the location that was imaged, or the location that was desired to be imaged? Those may be different if the satellite has a boresight misalignment or otherwise failed to point at.
(Admittedly, for defining ONA/azimuth/... at a whole scene, that target vs. scene difference is pretty negligible)
I'd also be interested in a more concrete definition of scene center, but I am unsure as to whether the definition is: