Move requests from optional dev dependencies to regular dependency#478
Open
matthewscottgordon wants to merge 2 commits intostac-utils:mainfrom
Open
Conversation
stac won't run without this dependency.
gadomski
approved these changes
Dec 19, 2024
Member
|
@matthewscottgordon CI failures aren't on you, this repo has a bit of bitrot. I'll try to clean things up today or tomorrow. Thanks for the contribution! After this is merged we can cut a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
#477
Description:
Moved the
requestsdependency fromoptional-dependencies.devtodependencies.The
requestspackage is used by the test_data module which is loaded byload_plugins()when you runstac. I'm not sure if this the right way to fix this; it's possible that that module shouldn't be loaded to begin with.PR checklist:
scripts/format).scripts/lint).scripts/test).