Skip to content

docs: Add FIXME note regarding smoke test teardown - #833

Merged
sbernauer merged 1 commit into
mainfrom
docs/test-teardown
Aug 4, 2026
Merged

docs: Add FIXME note regarding smoke test teardown#833
sbernauer merged 1 commit into
mainfrom
docs/test-teardown

Conversation

@sbernauer

Copy link
Copy Markdown
Member

Description

Follow-up of #789

Maybe we already did the proper fix already and can get rid of this?

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer
sbernauer requested a review from adwk67 August 4, 2026 11:16
@sbernauer sbernauer self-assigned this Aug 4, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 4, 2026

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this (problems with namespace teardown) is still a problem for tests running in some enviroments, so this reminder makes sense.

@NickLarsenNZ

NickLarsenNZ commented Aug 4, 2026

Copy link
Copy Markdown
Member

Maybe related to stackabletech/beku.py#39

Edit: Yep, see comment: stackabletech/beku.py#39 (review)

@sbernauer

Copy link
Copy Markdown
Member Author

Yeah, I saw that comment, funny coincidence we run into it at the same time

@sbernauer
sbernauer added this pull request to the merge queue Aug 4, 2026
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Aug 4, 2026
Merged via the queue into main with commit 29d7940 Aug 4, 2026
12 checks passed
@sbernauer
sbernauer deleted the docs/test-teardown branch August 4, 2026 11:29
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Aug 17, 2026
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants