-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: Support floating tag in product image selection #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
bba6907
2dc254d
e9d1bba
83531c7
50ded42
eee5f95
c0c9031
f760b36
7a02d0f
e730445
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1855,12 +1855,13 @@ spec: | |
| description: Version of the product, e.g. `1.4.1`. | ||
| type: string | ||
| pullPolicy: | ||
| default: Always | ||
| description: '[Pull policy](https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy) used when pulling the image.' | ||
| enum: | ||
| - IfNotPresent | ||
| - Always | ||
| - Never | ||
| - null | ||
| nullable: true | ||
| type: string | ||
| pullSecrets: | ||
| description: '[Image pull secrets](https://kubernetes.io/docs/concepts/containers/images/#specifying-imagepullsecrets-on-a-pod) to pull images from a private registry.' | ||
|
|
@@ -1886,12 +1887,41 @@ spec: | |
| type: string | ||
| stackableVersion: | ||
| description: |- | ||
| Stackable version of the product, e.g. `23.4`, `23.4.1` or `0.0.0-dev`. | ||
| Stackable version of the product, e.g. `26.7.0` or `0.0.0-dev`. | ||
|
|
||
| If not specified, the operator will use its own version, e.g. `23.4.1`. When using a nightly | ||
| If not specified, the operator will use its own version, e.g. `26.7.1`. When using a nightly | ||
| operator or a PR version, it will use the nightly `0.0.0-dev` image. | ||
|
|
||
| If this is used in combination with `useFloatingTag`, the correct floating tag is computed | ||
| automatically, e.g. `26.7.0` becomes `26.7` for the product image. | ||
| nullable: true | ||
| type: string | ||
| useFloatingTag: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bumping this up so we don't forget
|
||
| default: false | ||
| description: |- | ||
| Use a floating tag for the product image. Defaults to `false`. | ||
|
|
||
| This mechanism utilizes a floating image tag which always refers to the latest patch version | ||
| in the current release line. The current release line is either automatically derived by the | ||
| operator based on its own version, or can be overridden with `stackableVersion`. | ||
|
|
||
| A potential newer image is only pulled when Pods are rotated or their containers are | ||
| restarted. Pods are NOT rotated and containers are NOT restarted automatically when a new | ||
| image is available. This behaviour makes this a passive update mechanism, rather than an | ||
| active one. | ||
|
|
||
| It should be noted that when this field is set to `true`, the operator uses `Always` as the | ||
| pull policy for product images. If set to `false`, `IfNotPresent` is used. Explicitly | ||
| setting `pullPolicy` takes precedence. | ||
|
|
||
| ### Examples | ||
|
|
||
| - The `stackableVersion` field is not set, the operator falls back to its own version, eg. | ||
| 26.7.0. If this field is set to `true`, the `26.7` floating tag will be used for product | ||
| images, else, `26.7.0` will be used. | ||
| - The `stackableVersion` field is set to `26.3.0`. If this field is set to `true`, the | ||
| `26.3` floating tag will be used for product images, else, `26.3.0` will be used. | ||
| type: boolean | ||
| type: object | ||
| secretClassVolume: | ||
| properties: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.