Skip to content

feat: Add Key::new_trimmed helper function - #1260

Merged
sbernauer merged 12 commits into
mainfrom
feat/ensure-max-length-pub
Aug 10, 2026
Merged

feat: Add Key::new_trimmed helper function#1260
sbernauer merged 12 commits into
mainfrom
feat/ensure-max-length-pub

Conversation

@sbernauer

@sbernauer sbernauer commented Aug 5, 2026 •
edited by siegfriedweber
Loading

Copy link
Copy Markdown
Member

Description

I need this helper function to fix a bug in commons-operator: stackabletech/commons-operator#443

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Aug 5, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 5, 2026
@sbernauer sbernauer mentioned this pull request Aug 5, 2026
Merged
18 tasks
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 5, 2026
@Techassi
Techassi self-requested a review August 5, 2026 15:09
siegfriedweber
siegfriedweber requested changes Aug 5, 2026
View reviewed changes
Comment thread crates/stackable-operator/src/v2/macros/attributed_string_type.rs Outdated
Comment thread crates/stackable-operator/src/v2/role_group_utils.rs Outdated
@sbernauer sbernauer changed the title feat(v2): Make ResourceNames::ensure_max_length public feat: Add Key::shortened_to_valid_length helper function Aug 6, 2026
siegfriedweber
siegfriedweber requested changes Aug 6, 2026
View reviewed changes
Comment thread crates/stackable-operator/src/kvp/key.rs Outdated
Comment thread crates/stackable-operator/src/utils/length_enforcement.rs Outdated
siegfriedweber
siegfriedweber requested changes Aug 7, 2026
View reviewed changes
Comment thread crates/stackable-operator/src/utils/length_enforcement.rs Outdated
siegfriedweber
siegfriedweber previously approved these changes Aug 7, 2026
View reviewed changes

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Techassi
Techassi reviewed Aug 10, 2026
View reviewed changes
Comment thread crates/stackable-operator/src/kvp/key.rs Outdated
@sbernauer
sbernauer requested a review from Techassi August 10, 2026 09:00
@sbernauer
sbernauer enabled auto-merge August 10, 2026 11:11
@sbernauer sbernauer changed the title feat: Add Key::shortened_to_valid_length helper function feat: Add Key::new_trimmed helper function Aug 10, 2026
@sbernauer
sbernauer added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 82abe54 Aug 10, 2026
5 checks passed
@sbernauer
sbernauer deleted the feat/ensure-max-length-pub branch August 10, 2026 13:02
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 10, 2026
@siegfriedweber siegfriedweber mentioned this pull request Aug 14, 2026
Merged
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes
@Techassi Techassi Awaiting requested review from Techassi

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbernauer @Techassi @siegfriedweber @lfrancke