ci(template): Change operator version behaviour - #632
Merged
Conversation
Previously, we only used 0.0.0-prXXX for the image tag if the PR targeted the main branch. This could lead to surprising results, because some PRs might be raised against a different feature branch (potentially part of a different PR). In these cases, the current version (most likely 0.0.0-dev) would be used and the -prXXX was appended to it, resulting in a surprising version tag 0.0.0-dev-prXXX. To address this, we decided to only use the current version for PRs raised against release branches where this version scheme makes sense (that behaviour was also our intend when we initially wrote that script). For ANY other branch, we now always use 0.0.0-prXXX. We could further improve the logic by checking if the current version differs from 0.0.0-dev and then use the version as is with a -prXXX suffix. If the version is 0.0.0-dev, we use the established 0.0.0-prXXX version.
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only used 0.0.0-prXXX for the image tag if the PR targeted the main branch. This could lead to surprising results, because some PRs might be raised against a different feature branch (potentially part of a different PR). In these cases, the current version (most likely 0.0.0-dev) would be used and the -prXXX was appended to it, resulting in a surprising version tag 0.0.0-dev-prXXX.
To address this, we decided to only use the current version for PRs raised against release branches where this version scheme makes sense (that behaviour was also our intend when we initially wrote that script). For ANY other branch, we now always use 0.0.0-prXXX.
We could further improve the logic by checking if the current version differs from 0.0.0-dev and then use the version as is with a -prXXX suffix. If the version is 0.0.0-dev, we use the established 0.0.0-prXXX version.