Skip to content

chore: Upgrade stackable-operator to 0.110.0#878

Open
dervoeti wants to merge 2 commits intomainfrom
chore/upgrade-stackable-operator-0.110.0
Open

chore: Upgrade stackable-operator to 0.110.0#878
dervoeti wants to merge 2 commits intomainfrom
chore/upgrade-stackable-operator-0.110.0

Conversation

@dervoeti
Copy link
Copy Markdown
Member

@dervoeti dervoeti commented Apr 14, 2026

Description

Part of stackabletech/issues#844

Upgraded stackable-operator from 0.108.0 to 0.110.0.

Replaced the untyped HashMap<String, HashMap<String, String>> config overrides with a new TrinoConfigOverrides struct supports config.properties, node.properties, log.properties, security.properties, access-control.properties, exchange-manager.properties and spooling-manager.properties via KeyValueConfigOverrides.

Also removes the OIDC client auth method warning since the feature is now opt-in (stackabletech/operator-rs#1194).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Apr 14, 2026
@dervoeti dervoeti self-assigned this Apr 14, 2026
sbernauer
sbernauer previously approved these changes Apr 14, 2026
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor questions

#[serde(default, skip_serializing_if = "Option::is_none")]
pub coordinators:
Option<Role<TrinoConfigFragment, TrinoCoordinatorRoleConfig, JavaCommonConfig>>,
pub coordinators: Option<
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use TrinoCoordinatorRoleType here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch: ac46535

// no doc - it's in the struct.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub workers: Option<Role<TrinoConfigFragment, GenericRoleConfig, JavaCommonConfig>>,
pub workers: Option<
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use TrinoRoleType here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch: ac46535

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants