Fixed OOD shell timeout issue by injecting heartbeat function#14
Open
wtripp180901 wants to merge 2 commits intomainfrom
Open
Fixed OOD shell timeout issue by injecting heartbeat function#14wtripp180901 wants to merge 2 commits intomainfrom
wtripp180901 wants to merge 2 commits intomainfrom
Conversation
Collaborator
|
@wtripp180901 could you find a way of providing a diff between the upstream file and the one this PR injects please? It can just go into the first comment above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the OOD shell doesn't seem to be affected by either ClientAliveInterval in the sshd config or ServerAliveInterval in the ssh config. This only happens via the OOD shell, I tried ssh-ing from the login pod to itself as OOD would and the issue doesn't occur. This could potentially be a bug
https://discourse.openondemand.org/t/ssh-keep-alive-shell-access-on-ondemand/384/14
OSC/ondemand#2269
https://discourse.openondemand.org/t/novnc-and-shell-session-timeout-after-1-minute/1622
I found a horrible fix here:
https://discourse.openondemand.org/t/novnc-and-shell-session-timeout-after-1-minute/1622/6
I'm mounting the file from the OOD source with those changes in before startup
diffof modified app.js file with the original: