Added options in Helm chart for configuring external or internal database#34
Draft
wtripp180901 wants to merge 2 commits intomainfrom
Draft
Added options in Helm chart for configuring external or internal database#34wtripp180901 wants to merge 2 commits intomainfrom
wtripp180901 wants to merge 2 commits intomainfrom
Conversation
…ly managed database
sd109
approved these changes
Aug 29, 2023
Contributor
sd109
left a comment
sd109
left a comment
There was a problem hiding this comment.
LGTM, but let's wait until we can test somewhere before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can now choose to enable/disable internal database in the Helm chart and provided object to give connection details for external databases
Hasn't been tested properly yet because of Arcus issues and needs external DB to test with