Fix base path of Source type repos#438
Conversation
Summary of ChangesHello @seunghun1ee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the base paths for several Rocky Linux source repositories (versions 8.10 and 9.6) were incorrectly configured. The change updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the base paths for several Rocky Linux source repositories. The change from source/os/ to source/tree/ aligns with the directory structure of the upstream mirrors, resolving an issue that would prevent repository synchronization. The changes are accurate and necessary. I've added one suggestion regarding the structure of the configuration file to improve long-term maintainability by reducing repetition.
sjpb
left a comment
sjpb
left a comment
There was a problem hiding this comment.
LGTM, matches original PR and upstream repos
priteau
left a comment
priteau
left a comment
There was a problem hiding this comment.
EPEL source repositories use 8/Everything/source/tree/ and 9/Everything/source/tree/
On upstream source, their base path ends with ``source/tree/`` instead of ``source/os/``
seunghun1ee
force-pushed
the
fix-base-path-source-type-repo
branch
from
5ee7d27 to
1c4a1d2
Compare
|
Test is running at https://github.com/stackhpc/stackhpc-release-train/actions/runs/18158888504 |
* latest_timestamps.py: show url and status on failure eg to identify which pulp_path is incorrect * dnf_repo_timestamps.yml: sort * dnf_repo_timestamps.yml: update existing timestamps * dnf_repo_timestamps.yml: rocky 9.7 * Apply suggestions from code review epel everything source has now a tree subfolder See https://ark.stackhpc.com/pulp/content/epel/8/Everything/source/tree/ Co-authored-by: wtripp180901 <78219569+wtripp180901@users.noreply.github.com> * fixed epel source timestamps * updated timestamps * comment about running locally * match source repo path in stackhpc/stackhpc-release-train#438 * update repo timestamps * bump ci images * bump baseimage for openhpc-RL9 because if based on 9.6 image I stay on 9.6 yum repos * bump RL9 fatimage https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/20331802030/job/58408928975 * update repo timestamps * TMP? Fix RL8 fatimage build on SMS cloud * fatimage with Today's latest timestamps * doca: fix repo url starting with 3.2.0 it only includes the major version: ie rhel9 not rhel9.7 * doca 3.2.1 for RL 9.7 * packer: show ssh command to builder vm avoids loading the temporary inventory produced by tofu * update RL8 and RL9.7 timestamps [skip ci] * default fatimage build cloud to repo setting [skip ci] * bump CI image * fixup update_timestamps playbook instructions --------- Co-authored-by: wtripp180901 <78219569+wtripp180901@users.noreply.github.com> Co-authored-by: Steve Brasier <steveb@stackhpc.com>
* latest_timestamps.py: show url and status on failure eg to identify which pulp_path is incorrect * dnf_repo_timestamps.yml: sort * dnf_repo_timestamps.yml: update existing timestamps * dnf_repo_timestamps.yml: rocky 9.7 * Apply suggestions from code review epel everything source has now a tree subfolder See https://ark.stackhpc.com/pulp/content/epel/8/Everything/source/tree/ Co-authored-by: wtripp180901 <78219569+wtripp180901@users.noreply.github.com> * fixed epel source timestamps * updated timestamps * comment about running locally * match source repo path in stackhpc/stackhpc-release-train#438 * update repo timestamps * bump ci images * bump baseimage for openhpc-RL9 because if based on 9.6 image I stay on 9.6 yum repos * bump RL9 fatimage https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/20331802030/job/58408928975 * update repo timestamps * TMP? Fix RL8 fatimage build on SMS cloud * fatimage with Today's latest timestamps * doca: fix repo url starting with 3.2.0 it only includes the major version: ie rhel9 not rhel9.7 * doca 3.2.1 for RL 9.7 * packer: show ssh command to builder vm avoids loading the temporary inventory produced by tofu * update RL8 and RL9.7 timestamps [skip ci] * default fatimage build cloud to repo setting [skip ci] * bump CI image * fixup update_timestamps playbook instructions --------- Co-authored-by: wtripp180901 <78219569+wtripp180901@users.noreply.github.com> Co-authored-by: Steve Brasier <steveb@stackhpc.com>
* latest_timestamps.py: show url and status on failure eg to identify which pulp_path is incorrect * dnf_repo_timestamps.yml: sort * dnf_repo_timestamps.yml: update existing timestamps * dnf_repo_timestamps.yml: rocky 9.7 * Apply suggestions from code review epel everything source has now a tree subfolder See https://ark.stackhpc.com/pulp/content/epel/8/Everything/source/tree/ Co-authored-by: wtripp180901 <78219569+wtripp180901@users.noreply.github.com> * fixed epel source timestamps * updated timestamps * comment about running locally * match source repo path in stackhpc/stackhpc-release-train#438 * update repo timestamps * bump ci images * bump baseimage for openhpc-RL9 because if based on 9.6 image I stay on 9.6 yum repos * bump RL9 fatimage https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/20331802030/job/58408928975 * update repo timestamps * TMP? Fix RL8 fatimage build on SMS cloud * fatimage with Today's latest timestamps * doca: fix repo url starting with 3.2.0 it only includes the major version: ie rhel9 not rhel9.7 * doca 3.2.1 for RL 9.7 * packer: show ssh command to builder vm avoids loading the temporary inventory produced by tofu * update RL8 and RL9.7 timestamps [skip ci] * default fatimage build cloud to repo setting [skip ci] * bump CI image * fixup update_timestamps playbook instructions --------- Co-authored-by: wtripp180901 <78219569+wtripp180901@users.noreply.github.com> Co-authored-by: Steve Brasier <steveb@stackhpc.com>
3 participants
On upstream source, their base path ends with
source/tree/instead ofsource/os/