Skip to content

Generator: Update SDK /services/modelexperiments#7565

Open
stackit-pipeline wants to merge 1 commit into
mainfrom
oas-bot-26559046231/modelexperiments
Open

Generator: Update SDK /services/modelexperiments#7565
stackit-pipeline wants to merge 1 commit into
mainfrom
oas-bot-26559046231/modelexperiments

Conversation

@stackit-pipeline
Copy link
Copy Markdown
Contributor

Generated from GitHub run 26559046231
spec comparison:


// CreateInstanceTokenExecute executes the request
// @return CreateTokenResponse
CreateInstanceTokenExecute(r ApiCreateInstanceTokenRequest) (*CreateTokenResponse, error)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CreateInstanceTokenExecute(r ApiCreateInstanceTokenRequest) (*CreateTokenResponse, error)
CreateInstanceTokenExecute(r ApiCreateInstanceTokenRequest) (*CreateInstanceTokenResponse, error)


// DeleteInstanceTokenExecute executes the request
// @return DeleteTokenResponse
DeleteInstanceTokenExecute(r ApiDeleteInstanceTokenRequest) (*DeleteTokenResponse, error)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DeleteInstanceTokenExecute(r ApiDeleteInstanceTokenRequest) (*DeleteTokenResponse, error)
DeleteInstanceTokenExecute(r ApiDeleteInstanceTokenRequest) (*DeleteInstanceTokenResponse, error)


// GetInstanceTokenExecute executes the request
// @return GetTokenResponse
GetInstanceTokenExecute(r ApiGetInstanceTokenRequest) (*GetTokenResponse, error)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GetInstanceTokenExecute(r ApiGetInstanceTokenRequest) (*GetTokenResponse, error)
GetInstanceTokenExecute(r ApiGetInstanceTokenRequest) (*GetInstanceTokenResponse, error)


// ListInstanceTokensExecute executes the request
// @return ListTokenResponse
ListInstanceTokensExecute(r ApiListInstanceTokensRequest) (*ListTokenResponse, error)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ListInstanceTokensExecute(r ApiListInstanceTokensRequest) (*ListTokenResponse, error)
ListInstanceTokensExecute(r ApiListInstanceTokensRequest) (*ListInstanceTokenResponse, error)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally: Plural vs Singular
Plural: ListInstanceTokensExecute
Response it is singular: ListTokenResponse

@param instanceId instance id
@return ApiPartialUpdateInstanceTokenRequest
*/
PartialUpdateInstanceToken(ctx context.Context, projectId string, regionId string, tId string, instanceId string) ApiPartialUpdateInstanceTokenRequest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tId should have a clear name e.g. tokenId like the other parameters


// PartialUpdateInstanceTokenExecute executes the request
// @return PartialUpdateTokenResponse
PartialUpdateInstanceTokenExecute(r ApiPartialUpdateInstanceTokenRequest) (*PartialUpdateTokenResponse, error)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PartialUpdateInstanceTokenExecute(r ApiPartialUpdateInstanceTokenRequest) (*PartialUpdateTokenResponse, error)
PartialUpdateInstanceTokenExecute(r ApiPartialUpdateInstanceTokenRequest) (*PartialUpdateInstanceTokenResponse, error)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check every method please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants