Add store support for Spin adapter (KV, config, secret) by prk-Jr · Pull Request #253 · stackpop/edgezero

prk-Jr · 2026-04-24T17:31:27Z

Summary

Implements SpinKvStore, SpinConfigStore, and SpinSecretStore so Spin handlers can access key-value, configuration, and secret data through the same ctx.kv_handle(), ctx.config_store(), and ctx.secret_handle() API as every other adapter.
Wires all three store handles into the Spin request dispatch pipeline so they are available on every request without any extra setup in user code.
Adds a spin-adapter-tests CI job, store injection contract tests, and Spin support to all three smoke test scripts.

Changes

Crate / File	Change
`crates/edgezero-adapter-spin/src/config_store.rs`	New — `SpinConfigStore` backed by `spin_sdk::variables`; dual-backend (Spin / in-memory for tests); contract tests via macro
`crates/edgezero-adapter-spin/src/key_value_store.rs`	New — `SpinKvStore` backed by `spin_sdk::key_value`; in-process prefix filter + pagination; configurable `max_list_keys` cap (warn + truncate); TTL silently ignored
`crates/edgezero-adapter-spin/src/secret_store.rs`	New — `SpinSecretStore` backed by `spin_sdk::variables`; key normalised to lowercase to match Spin variable naming rules
`crates/edgezero-adapter-spin/src/request.rs`	`dispatch()` now injects `ConfigStoreHandle`, `KvHandle`, and `SecretHandle` into every request's extensions
`crates/edgezero-adapter-spin/src/lib.rs`	Re-exports new store types
`crates/edgezero-adapter-spin/tests/contract.rs`	Store injection smoke tests + wasm32 compile-time trait checks for `SpinKvStore` and `SpinSecretStore`
`crates/edgezero-core/src/manifest.rs`	Added `"spin"` to `SUPPORTED_CONFIG_STORE_ADAPTERS`
`crates/edgezero-core/src/config_store.rs`	Updated `ConfigStore` trait doc to list `SpinConfigStore`
`.github/workflows/test.yml`	New `spin-adapter-tests` job: native tests + wasm32-wasip1 compilation check
`examples/app-demo/crates/app-demo-adapter-spin/spin.toml`	Added `key_value_stores = ["default"]` binding and variable declarations for `greeting` and `smoke_secret`
`examples/app-demo/edgezero.toml`	Added `"spin"` to `adapters` for config, KV, and secrets routes
`scripts/smoke_test_kv.sh`	Added `spin` case
`scripts/smoke_test_config.sh`	Added `spin` case; skips dotted-key checks (Spin variable names cannot contain dots)
`scripts/smoke_test_secrets.sh`	Added `spin` case; passes secret value via `SPIN_VARIABLE_SMOKE_SECRET` at startup
`.gitignore`	Added `.spin/` (runtime SQLite KV database and component logs)

Closes

Closes #73
Closes #74

Test plan

cargo test --workspace --all-targets
cargo clippy --workspace --all-targets --all-features -- -D warnings
cargo check --workspace --all-targets --features "fastly cloudflare spin"
WASM builds: cargo check -p edgezero-adapter-spin --target wasm32-wasip1 --features spin
./scripts/smoke_test_kv.sh spin
./scripts/smoke_test_config.sh spin
./scripts/smoke_test_secrets.sh spin

Checklist

Changes follow CLAUDE.md conventions
No Tokio deps added to core or adapter crates
Route params use {id} syntax (not :id)
Types imported from edgezero_core (not http crate)
New code has tests
No secrets or credentials committed

… module

…ait docs

…ariables)

- dispatch() in request.rs now injects ConfigStoreHandle, KvHandle, and SecretHandle into request extensions on every request - SpinSecretStore normalises the lookup key to lowercase so conventional uppercase names (e.g. SMOKE_SECRET) resolve to the correct Spin variable - contract.rs gains store injection smoke tests (config, kv, secret) and wasm32 compile-time trait checks for SpinKvStore and SpinSecretStore

- spin.toml gains key_value_stores = ["default"] binding and variables declarations for greeting and smoke_secret - edgezero.toml adds "spin" to adapters for config, kv, and secrets routes - smoke_test_kv/config/secrets.sh each gain a spin case that builds the WASM binary and starts spin up --listen 127.0.0.1:3000; the config script skips dotted-key checks (Spin variable names cannot contain dots); the secrets script passes SPIN_VARIABLE_SMOKE_SECRET at startup

spin up creates .spin/ (SQLite KV database and component logs) in the adapter directory during local development, mirroring .wrangler/ for CF.

instead of silently truncating; callers now get an explicit signal rather than incomplete pagination results - Correct DEFAULT_MAX_LIST_KEYS, with_max_list_keys, and module-level docs to accurately describe error-return behaviour (not truncation, not "unbounded allocation" guarding) - Add log::debug in SpinSecretStore::get_bytes when store_name is non-empty so callers learn the flat-namespace constraint at runtime - Add comment in config_store contract tests explaining the InMemory backend accepts dotted/uppercase keys that the real Spin backend would reject via InvalidName - Add comment in lib.rs explaining why SpinConfigStore has different feature gating than SpinKvStore and SpinSecretStore

ChristianPavilonis

Summary

Thanks for adding Spin store support and the smoke/CI coverage. CI is green. I found two configuration-semantics issues worth addressing before relying on non-default store names: Spin KV dispatch is hard-coded to default, and accepting a Spin config-store adapter override is misleading because the runtime does not consume that name.

ChristianPavilonis · 2026-05-04T14:39:36Z

+        .extensions_mut()
+        .insert(ConfigStoreHandle::new(Arc::new(SpinConfigStore::new())));
+
+    match SpinKvStore::open_default() {


Spin dispatch ignores manifest-configured KV store names

Severity: P1

dispatch() always opens SpinKvStore::open_default(). That means [stores.kv].name or [stores.kv.adapters.spin].name from edgezero.toml cannot affect the injected handle, unlike the other adapters' manifest-aware run_app paths. Apps configured to use a non-default Spin KV label will silently get the wrong label or no KV handle.

Suggestion: Make the Spin entrypoint/dispatch path manifest-aware and resolve the configured Spin KV label before opening the store, or reject/document Spin KV store-name configuration until the runtime can honor it.

ChristianPavilonis · 2026-05-04T14:39:36Z


 pub const DEFAULT_CONFIG_STORE_NAME: &str = "EDGEZERO_CONFIG";
-const SUPPORTED_CONFIG_STORE_ADAPTERS: &[&str] = &["axum", "cloudflare", "fastly"];
+const SUPPORTED_CONFIG_STORE_ADAPTERS: &[&str] = &["axum", "cloudflare", "fastly", "spin"];


Spin config-store adapter overrides are accepted but not used by the Spin runtime

Severity: P2

This change makes [stores.config.adapters.spin] pass validation, but edgezero_adapter_spin::run_app does not take edgezero.toml and dispatch() injects SpinConfigStore::new() directly. Since Spin variables are a flat namespace, the configured name/adapter override has no effect at runtime.

Suggestion: Either keep spin rejected for config-store adapter-name overrides, or update the runtime/docs so users know Spin config values come from component variables and the configured store name is ignored.

prk-Jr added 14 commits April 24, 2026 20:05

feat: allow spin as a supported config store adapter

32998df

docs: update adapters field comment to include spin

1022cd7

feat: add SpinConfigStore backed by spin_sdk::variables

5bb8051

fix: rename SpinConfigBackend and remove feature gate on config_store…

d64e95d

… module

fix: fmt ordering in lib.rs and add SpinConfigStore to ConfigStore tr…

53dfa1c

…ait docs

feat: add SpinSecretStore backed by spin_sdk::variables

917ff57

feat: add SpinKvStore backed by spin_sdk::key_value

8a4e227

chore: remove stale 'not yet implemented' note from run_app doc comment

ac8facb

ci: add spin-adapter-tests job

a0ec8e6

fix: handle InvalidName in SpinSecretStore and restore allow(unused_v…

cf57f58

…ariables)

feat: add configurable max_list_keys cap to SpinKvStore

ec7dc14

chore: ignore .spin/ runtime directory

58c7b6e

spin up creates .spin/ (SQLite KV database and component logs) in the adapter directory during local development, mirroring .wrangler/ for CF.

prk-Jr self-assigned this Apr 24, 2026

prk-Jr added 2 commits April 25, 2026 18:12

fix CI cache conflict

c001103

prk-Jr requested review from ChristianPavilonis and aram356 April 25, 2026 12:49

prk-Jr added 3 commits April 29, 2026 14:40

Fix test.yml to use matrix run

3b995e5

Fix pin viceroy pin and wasmtime install flag

4644225

Fix type mismatch for wasm32-wasip1

ff0633b

ChristianPavilonis reviewed May 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add store support for Spin adapter (KV, config, secret)#253

Add store support for Spin adapter (KV, config, secret)#253
prk-Jr wants to merge 19 commits intomainfrom
feat/spin-store-support

prk-Jr commented Apr 24, 2026

Uh oh!

ChristianPavilonis left a comment

Uh oh!

ChristianPavilonis May 4, 2026

Uh oh!

ChristianPavilonis May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

prk-Jr commented Apr 24, 2026

Summary

Changes

Closes

Test plan

Checklist

Uh oh!

ChristianPavilonis left a comment

Choose a reason for hiding this comment

Summary

Uh oh!

ChristianPavilonis May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ChristianPavilonis May 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants