Skip to content

Conversation

@bradr5
Copy link
Contributor

@bradr5 bradr5 commented Jan 27, 2026

Description

Fixes all UI related issues found during testing

Changes:

  • Capitalized "cve" inside of severity count tooltip
  • Prevent "Virtual machines" header from being truncated in the overview table
  • Fixed capitalization in header text
  • Added "Guest OS" label under details page header
  • Removed "# of results" text above all tables

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

1. Capitalized "cve" inside of severity count tooltip

Screenshot 2026-01-27 at 12 22 25 PM

2. Prevent "Virtual machines" header from being truncated in the overview table

Screenshot 2026-01-27 at 12 22 48 PM

3. Fixed capitalization in header text

Screenshot 2026-01-27 at 12 23 12 PM

4. Added "Guest OS" label under details page header

Screenshot 2026-01-27 at 12 24 59 PM

5. Removed "# of results" text above all tables

Screenshot 2026-01-27 at 12 28 24 PM Screenshot 2026-01-27 at 12 28 38 PM Screenshot 2026-01-27 at 12 28 48 PM

@bradr5 bradr5 requested a review from a team as a code owner January 27, 2026 18:37
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 27, 2026

Images are ready for the commit at d80cbd6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-930-gd80cbd6d38.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.37%. Comparing base (e84978e) to head (d80cbd6).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18700      +/-   ##
==========================================
+ Coverage   49.36%   49.37%   +0.01%     
==========================================
  Files        2663     2663              
  Lines      200562   200562              
==========================================
+ Hits        99013    99037      +24     
+ Misses      94098    94080      -18     
+ Partials     7451     7445       -6     
Flag Coverage Δ
go-unit-tests 49.37% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradr5 bradr5 force-pushed the bradr/ROX-31574_vm4vm_bug_bash_fixes branch from d0c9083 to d80cbd6 Compare January 27, 2026 20:39
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@bradr5: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-20-ui-e2e-tests d80cbd6 link false /test ocp-4-20-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants