fix: allow underscores in domain labels#2057
Open
lu-zero wants to merge 1 commit into
Open
Conversation
The domain validation regex `/^[a-z0-9-]+$/i` rejects underscores, preventing queries for DKIM, DMARC, SRV, and TLSA records which require underscore-prefixed labels (e.g., `_dmarc.example.com`). Per RFC 2181 §11, any binary label up to 63 octets is valid in DNS. The no-underscore restriction is a hostname convention, not a DNS protocol requirement. Fixes stacksjs#2056
✅ Deploy Preview for dnsx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2056
The domain validation regex rejects underscores, preventing queries for DKIM, DMARC, SRV, and TLSA records which use underscore-prefixed labels (e.g.,
_dmarc.example.com,selector1._domainkey.example.com).One-character fix:
[a-z0-9-]→[a-z0-9_-]invalidateDomainName.Per RFC 2181 §11, any binary label up to 63 octets is valid in DNS. The no-underscore restriction is a hostname convention (RFC 952), not a DNS protocol requirement.
Added test covering DKIM, DMARC, and SRV domain patterns.