Skip to content

Fix key event issues #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maiko3tattun wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix key event issues #1920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c700d9
Fix mishandled key event
Jan 11, 2026
2dda697
Fix textbox focus in note properties panel
Jan 11, 2026
e520e26
resolve conflict
Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion OpenUtau/Controls/NotePropertiesControl.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:vm="using:OpenUtau.App.ViewModels"
mc:Ignorable="d" d:DesignWidth="400" d:DesignHeight="600" Width="400"
x:Class="OpenUtau.App.Controls.NotePropertiesControl" KeyDown="OnKeyDown" Margin="0">
x:Class="OpenUtau.App.Controls.NotePropertiesControl"
KeyDown="OnKeyDown" Focusable="True">
<UserControl.Styles>
<Style Selector="Button,CheckBox">
<Setter Property="Focusable" Value="False"/>
Expand Down
12 changes: 8 additions & 4 deletions OpenUtau/Controls/PianoRoll.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,8 +1294,8 @@ bool OnKeyExtendedHandler(KeyEventArgs args) {
}
break;
case Key.F11:
OnMenuFullScreen(RootWindow, new RoutedEventArgs());
break;
OnMenuFullScreen(this, new RoutedEventArgs());
return true;
case Key.Enter:
if (isNone) {
if (notesVm.Selection.Count == 1) {
Expand Down Expand Up @@ -1455,6 +1455,7 @@ bool OnKeyExtendedHandler(KeyEventArgs args) {
}
if (isAlt) {
SnapDivMenu.Open();
return true;
}
break;
case Key.OemPipe:
Expand Down Expand Up @@ -1734,6 +1735,7 @@ bool OnKeyExtendedHandler(KeyEventArgs args) {
// mute
if (isShift) {
MessageBus.Current.SendMessage(new TracksMuteEvent(notesVm.Part.trackNo, false));
return true;
}
break;
case Key.F:
Expand Down Expand Up @@ -1792,13 +1794,15 @@ bool OnKeyExtendedHandler(KeyEventArgs args) {
#region move to the next track part
case Key.PageUp: {
if (isNone) {
return MoveToNextPart(false);
MoveToNextPart(false);
return true;
}
}
break;
case Key.PageDown: {
if (isNone) {
return MoveToNextPart(true);
MoveToNextPart(true);
return true;
}
}
break;
Expand Down
Loading