Skip to content

Simplify RoomContext color lookup to key by sender name for consistent colors #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomastiminskas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify RoomContext color lookup to key by sender name for consistent colors #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions com.stakwork.sphinx.desktop/Scenes/Dashboard/Live Kit/Views/RoomContext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,19 +438,9 @@ extension RoomContext {
return randomColor
}

/// Returns the color for a chat message sender, matching the live participant
/// box color when the sender name corresponds to a connected participant.
func getColorForMessage(senderName: String?) -> Color {
// Try to find a live participant whose name or identity matches the sender
if let senderName = senderName,
let match = room.allParticipants.values.first(where: {
$0.name == senderName || $0.identity?.stringValue == senderName
}) {
// Use the same key as participant boxes so colors stay in sync
let participantKey = match.sid?.stringValue ?? match.identity?.stringValue
return getColorForParticipan(participantId: participantKey)
}
// No live participant match — key by sender name
// Always key by senderName so history and live messages
// from the same sender share the same cached color.
return getColorForParticipan(participantId: senderName)
}
}
Expand Down