Skip to content

Generated with Hive: Fix message label clipping in NewOnlyTextMessageCollectionViewitem by adding explicit height constraint #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomastiminskas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Generated with Hive: Fix message label clipping in NewOnlyTextMessageCollectionViewitem by adding explicit height constraint #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdce933
Generated with Hive: Fix message label clipping in NewOnlyTextMessage…
tomastiminskas Apr 3, 2026
1420b86
Generated with Hive: Fix text clipping by preserving wraps and enabli…
tomastiminskas Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.stakwork.sphinx.desktop/Custom Classes/PaddedTextFieldCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ class PaddedTextField: CCTextField {
paddedCell.placeholderString = existingCell.placeholderString
paddedCell.lineBreakMode = existingCell.lineBreakMode
paddedCell.truncatesLastVisibleLine = existingCell.truncatesLastVisibleLine
paddedCell.wraps = existingCell.wraps
}

self.cell = paddedCell
Expand Down
2 changes: 2 additions & 0 deletions ...ew Chat View/Message Collection View Item/NewMessageCollectionViewItem+GeneralSetup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ extension NewMessageCollectionViewItem {
func setupViews() {
messageLabel.setSelectionColor(color: NSColor.getTextSelectionColor())
messageLabel.allowsEditingTextAttributes = true
messageLabel.maximumNumberOfLines = 0
messageLabel.cell?.wraps = true

receivedArrow.drawReceivedBubbleArrow(color: NSColor.Sphinx.ReceivedMsgBG)
sentArrow.drawSentBubbleArrow(color: NSColor.Sphinx.SentMsgBG)
Expand Down
11 changes: 10 additions & 1 deletion ...yTextMessageCollectionViewItem/NewOnlyTextMessageCollectionViewitem+LayoutExtension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,17 @@ extension NewOnlyTextMessageCollectionViewitem {

func configureWith(
messageContent: BubbleMessageLayoutState.MessageContent?,
searchingTerm: String?
messageCellState: MessageTableCellState,
searchingTerm: String?,
collectionViewWidth: CGFloat
) {
let labelHeight = ChatHelper.getTextMessageHeightFor(
messageCellState,
collectionViewWidth: collectionViewWidth
)
labelHeightConstraint.constant = labelHeight
textMessageView.superview?.layoutSubtreeIfNeeded()

if let messageContent = messageContent {
if messageContent.hasNoMarkdown && searchingTerm == nil {
messageLabel.attributedStringValue = NSMutableAttributedString(string: "")
Expand Down
7 changes: 6 additions & 1 deletion ...Chat View/NewOnlyTextMessageCollectionViewItem/NewOnlyTextMessageCollectionViewitem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class NewOnlyTextMessageCollectionViewitem: CommonNewMessageCollectionViewitem,

///Constraints
@IBOutlet weak var bubbleWidthConstraint: NSLayoutConstraint!
@IBOutlet weak var labelHeightConstraint: NSLayoutConstraint!

///Thirs Container
@IBOutlet weak var textMessageView: NSView!
Expand Down Expand Up @@ -52,6 +53,8 @@ class NewOnlyTextMessageCollectionViewitem: CommonNewMessageCollectionViewitem,

messageLabel.setSelectionColor(color: NSColor.getTextSelectionColor())
messageLabel.allowsEditingTextAttributes = true
messageLabel.maximumNumberOfLines = 0
messageLabel.cell?.wraps = true

let lineFrame = CGRect(
x: 0.0,
Expand Down Expand Up @@ -106,7 +109,9 @@ class NewOnlyTextMessageCollectionViewitem: CommonNewMessageCollectionViewitem,
///Text message content
configureWith(
messageContent: mutableMessageCellState.messageContent,
searchingTerm: searchingTerm
messageCellState: mutableMessageCellState,
searchingTerm: searchingTerm,
collectionViewWidth: collectionViewWidth
)

///Header and avatar
Expand Down
2 changes: 2 additions & 0 deletions ...w Chat View/NewOnlyTextMessageCollectionViewItem/NewOnlyTextMessageCollectionViewitem.xib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
<constraint firstItem="7nT-GT-4h9" firstAttribute="leading" relation="greaterThanOrEqual" secondItem="d54-Qo-HA4" secondAttribute="leading" id="rR7-3W-nxf"/>
<constraint firstItem="7nT-GT-4h9" firstAttribute="leading" secondItem="d54-Qo-HA4" secondAttribute="leading" id="w2g-8z-QSW"/>
<constraint firstAttribute="trailing" secondItem="7nT-GT-4h9" secondAttribute="trailing" id="zAt-KU-ECV"/>
<constraint firstAttribute="height" constant="48" id="hJB-h5-cNj-only"/>
</constraints>
</customView>
</subviews>
Expand Down Expand Up @@ -261,6 +262,7 @@
<outlet property="sentMessageMenuButton" destination="RqW-7V-PIs" id="2bU-AU-QHf"/>
<outlet property="statusHeaderView" destination="pCr-jf-cNZ" id="cWy-hb-E5V"/>
<outlet property="statusHeaderViewContainer" destination="9rC-bS-7Ll" id="6WL-tm-vMv"/>
<outlet property="labelHeightConstraint" destination="hJB-h5-cNj-only" id="lHC-on-ly1"/>
<outlet property="textMessageView" destination="d54-Qo-HA4" id="yRC-tJ-VmA"/>
<outlet property="view" destination="Hz6-mo-xeY" id="BkZ-7O-Bm8"/>
</connections>
Expand Down