Skip to content

run prettier in github actions#435

Merged
kevkevinpal merged 1 commit into
stakwork:masterfrom
antonilol:ghactions-prettier
Nov 4, 2022
Merged

run prettier in github actions#435
kevkevinpal merged 1 commit into
stakwork:masterfrom
antonilol:ghactions-prettier

Conversation

@antonilol
Copy link
Copy Markdown
Contributor

@antonilol antonilol commented Sep 16, 2022 •
edited
Loading

title

draft pr for now because i dont want this merged before #423 (it will be a pain to rebase that pr with many little changes this produces)

@kevkevinpal
Copy link
Copy Markdown
Contributor

kevkevinpal commented Sep 23, 2022

is there anyway of running prettier on the PR itself when someone opens to master so the diff is never ugly incase someone auto formats to prettier with their own config?

@antonilol
Copy link
Copy Markdown
Contributor Author

antonilol commented Sep 23, 2022

is there anyway of running prettier on the PR itself when someone opens to master so the diff is never ugly incase someone auto formats to prettier with their own config?

I tried this with the auto build but it didnt seem to work, even with the "Allow edits from maintainers" setting turned on

@antonilol
Copy link
Copy Markdown
Contributor Author

antonilol commented Sep 27, 2022 •
edited
Loading

just realized i can run prettier on other prs and merge/rebase should go fine because both branches contain the same change

@antonilol antonilol marked this pull request as ready for review September 27, 2022 21:52
@antonilol
Copy link
Copy Markdown
Contributor Author

antonilol commented Sep 29, 2022 •
edited
Loading

rebased + also formats .github/**/*.yml now

@antonilol antonilol mentioned this pull request Oct 2, 2022
Closed
@antonilol antonilol force-pushed the ghactions-prettier branch 3 times, most recently from 5cc2f6c to f13d4ad Compare October 4, 2022 19:17
@antonilol
Copy link
Copy Markdown
Contributor Author

antonilol commented Oct 4, 2022

is there anyway of running prettier on the PR itself when someone opens to master so the diff is never ugly incase someone auto formats to prettier with their own config?

it would actually be really annoying to have a script continuously push commits to a development branch when rebasing and merging, etc. i think it would really mess things up

@antonilol
Copy link
Copy Markdown
Contributor Author

antonilol commented Oct 20, 2022

rebased

kevkevinpal
kevkevinpal approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@kevkevinpal kevkevinpal merged commit 42d99a7 into stakwork:master Nov 4, 2022
@antonilol antonilol deleted the ghactions-prettier branch November 5, 2022 12:22
@antonilol antonilol mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kevkevinpal kevkevinpal kevkevinpal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonilol @kevkevinpal