Skip to content

Feat/add badge to tribe#582

Closed
tobi-bams wants to merge 31 commits into
masterfrom
feat/add-badge-to-tribe
Closed

Feat/add badge to tribe#582
tobi-bams wants to merge 31 commits into
masterfrom
feat/add-badge-to-tribe

Conversation

@tobi-bams
Copy link
Copy Markdown
Collaborator

PR Summary

  1. Created the add badge to tribe endpoint
  2. Updated the badge bot logic to use the new mapping table instead of the meta field in the chat bot
  3. Changed the create command for the badge bot to add and the logic also
  4. Updated the badge bor test to accommodate the current badge workflow
  5. Made a little change to the response returned by the create badge endpoint

Copy link
Copy Markdown
Contributor

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@Evanfeenstra
Copy link
Copy Markdown
Contributor

@tobi-bams rewardType and rewardRequirement need to be stored on the badge ALSO. These are "default values" when the Badge is added to the Tribe (the frontend will grab the defaults when pulling badges... you dont need to worry about copying the "default values" in the backend)

Copy link
Copy Markdown
Contributor

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Copy link
Copy Markdown
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kevkevinpal
Copy link
Copy Markdown
Contributor

closing as this PR included these changes
#593

@kevkevinpal kevkevinpal closed this Feb 7, 2023
@tobi-bams tobi-bams mentioned this pull request Feb 7, 2023
@kevkevinpal kevkevinpal reopened this Feb 7, 2023
@kevkevinpal
Copy link
Copy Markdown
Contributor

@tobi-bams let me know if I resolved these conflicts correctly 7908cbe

@kevkevinpal
Copy link
Copy Markdown
Contributor

ok this one can be closed

@kevkevinpal kevkevinpal closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants