Skip to content

fix: added lenient configs for file download timeouts #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thor963 wants to merge 2 commits into
base: alpha
Choose a base branch
from
Open

fix: added lenient configs for file download timeouts #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de6ce24
fix: added lenient configs for file download timeouts
Thor963 Mar 2, 2026
7c6d889
chore: corrected alpha version
Thor963 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ios/main/StallionFileDownloader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ import Foundation
import ZIPFoundation

class StallionFileDownloader: NSObject {
private lazy var urlSession = URLSession(configuration: .default,
delegate: self,
delegateQueue: nil)
private lazy var urlSession: URLSession = {
let configuration = URLSessionConfiguration.default
configuration.timeoutIntervalForRequest = 540.0 // 9 minutes per request
configuration.timeoutIntervalForResource = 3600.0 // 1 hour total
configuration.waitsForConnectivity = true
return URLSession(configuration: configuration, delegate: self, delegateQueue: nil)
}()
private var downloadTask: URLSessionDownloadTask?
private var _resolve: RCTPromiseResolveBlock?
private var _reject: RCTPromiseRejectBlock?
Expand Down Expand Up @@ -65,9 +69,9 @@ class StallionFileDownloader: NSObject {
let downloadFolder = URL(fileURLWithPath: downloadDirectory, isDirectory: true)
let fileManager = FileManager.default

// Delete existing folder if it exists
// Delete existing folder if it exists (ignore errors - we'll create it anyway)
if fileManager.fileExists(atPath: downloadFolder.path) {
try fileManager.removeItem(at: downloadFolder)
try? fileManager.removeItem(at: downloadFolder)

@general-maximus-decimus general-maximus-decimus Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thor963 , Can you please explain the comment you have added here ?

}

// Create new download folder
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-stallion",
"version": "2.4.0-alpha.4",
"version": "2.4.0-alpha.6",
"description": "Offical React Native SDK for Stallion",
"main": "index",
"types": "types/index.d.ts",
Expand Down