feat: custom base url support#109
Conversation
![stalliondevx[bot]](https://avatars.githubusercontent.com/in/3085194?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 StallionDevX AI Review
Quality Score: █████████░ 90/100
Verdict: comment
Summary
This pull request introduces support for a custom base URL across Android, iOS, and JavaScript components. The implementation is thorough, covering configuration storage, API constant updates, and integration into the API client. The use of a shared StallionApiBaseUrl utility on native platforms and getApiBaseUrl on JS ensures consistency and centralizes logic. Caching for the base URL in JS is a good performance optimization.
Overall, the feature is well-implemented and follows good practices for cross-platform development. The deprecation strategy for old constants is also well-handled.
🔵 Info (3)
- Broad Exception Catch and Silent Failure (maintainability) —
android/src/main/java/com/stallion/StallionModule.java:69
Catching a genericExceptionand only callinge.printStackTrace()can hide specific issues and make debugging harder. For a library, it's often better to log the error more explicitly or throw a more specific exception if the error is unrecoverable. - Broad Exception Catch and Silent Failure in Setter (maintainability) —
android/src/main/java/com/stallion/utils/StallionApiBaseUrl.java:37
Similar toStallionModule.java, catching a genericExceptionand silently failing in thesetmethod can obscure problems. While silent failure might be intended, it's good practice to at least log the error for debugging purposes. - Unintended Build Configuration Change in Example Project (style) —
example/ios/StallionExample.xcodeproj/xcshareddata/xcschemes/StallionExample.xcscheme:41
The build configuration for theLaunchActionin the example project's scheme was changed fromReleasetoDebug. While this is in an example project, it might be an unintentional change for a feature PR.
…-stallion into feat/custom-base-url
|
🎉 This PR is included in version 2.4.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.5.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Summary
This pull request introduces support for a custom base URL across Android, iOS, and JavaScript components. The implementation is thorough, covering configuration storage, API constant updates, and integration into the API client. The use of a shared
StallionApiBaseUrlutility on native platforms andgetApiBaseUrlon JS ensures consistency and centralizes logic. Caching for the base URL in JS is a good performance optimization.Overall, the feature is well-implemented and follows good practices for cross-platform development. The deprecation strategy for old constants is also well-handled.
Generated by StallionDevX