Open
Conversation
* upstream/master: syncing my accepted pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As MapBox, OSM, and others are adopting Vector tile formats, it is useful to provide the ability to obtain the tiles through this simple API and not assume they are images to be stitched together. This changeset includes a minor refactoring of the existing code such that a new method is exposed which returns the TileQueue post-fetch by including a base method in the Provider API which can be overridden when non-image tiles will be returned.
I pondered renaming the internal storage and access api (imgs / images()), or diverting the data into an alternate variable/function. However, I wasn't sure if that was necessary since python won't care what data it's obtaining anyhow. would love some feedback on this though.