Producer push method to return an executing Promise#10
Open
jamescway wants to merge 77 commits intostancampbell3:masterfrom
Open
Producer push method to return an executing Promise#10jamescway wants to merge 77 commits intostancampbell3:masterfrom
jamescway wants to merge 77 commits intostancampbell3:masterfrom
Conversation
JIRA: REL-1051
JIRA: REL-1051
Conflicts: hermann.iml
This change: - removes the platform specific binding (Ruby will run extconf.rb on platforms) - adds myself to the authors - Pulls version from the gem itself - includes all the files in lib that are added to the git tree
This is a little bit better and cleaner IMO than the hand-crafted rake tasks. Would you like to know more? <https://github.com/luislavena/rake-compiler>
Some are intentionally left out of the fixing because I believe there's a failing test case that needs to be added
…-configured broker/topic This will make it a bit easier to run local tests in a more automated fashion against some non-public broker hostnames
…without having started requests
…he rd_kafka_poll calls This also introduces some more/better error handling in Hermann::Lib::Producer#tick Fixes #24
…fely block for a value This adds a requirement for 1.8.7 clients to install the SystemTimer gem for timing out on Hermann::Result#value(timeout) to block and timeout correctly Fixes #25
…by-based busyloop
… change Producer data This will help with determining whether we're no longer connected due to failures after a push of a message
…ck is invoked Fixes #25
Add lots more machinery to help identify errors outside of a `push` command
Provided that Producer#tick_reactor has been invoked, if there are underlying errors like "1/1 Brokers down" then this code will ensure that outstanding Herman::Result children of Herman::Producer will have their error status updated. Fixes #25
Just a quick reproduction case for #32
Propagate systemic errors from librdkafka up into Herman::Result objects
…ngs from Ruby properly Fixes #32
Avoid call to rb_string_value_cstr() which doesn't handle binary strings properly
This reduces the need for the librdkafka system dependency and results in statically linking librdkafka.a against the C extension. There's a few hacks in extconf.rb specifically to deal with librdkafka's build system, as well as apply checksumming to the downloaded file Fixes #8
Bundle librdkafka 0.8.4 with the gem
Java Producer Provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the Promise creation to have it immediately start executing the code block. The returned promise is executing.