Skip to content

fix: Fixes forwarding of keyboard shortcut events #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antsgar merged 1 commit into from
Jul 8, 2026
Merged

fix: Fixes forwarding of keyboard shortcut events #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions dist/@types/ComponentRelay.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export default class ComponentRelay {
deinit(): void;
private registerMessageHandler;
private registerKeyboardEventListeners;
/**
* Only forward keyboard events involving shortcut modifiers (Ctrl, Shift, Meta, Alt).
* Plain typing should stay in the editor and not be sent to the parent app.
*/
private shouldForwardKeyboardEvent;
private forwardKeyboardEvent;
private registerMouseEventListeners;
private handleMessage;
private onReady;
Expand Down Expand Up @@ -149,16 +155,6 @@ export default class ComponentRelay {
* @param height The new height.
*/
setSize(width: string | number, height: string | number): void;
/**
* Sends the KeyDown keyboard event to the Standard Notes parent application.
* @param keyboardModifier The keyboard modifier that was pressed.
*/
private keyDownEvent;
/**
* Sends the KeyUp keyboard event to the Standard Notes parent application.
* @param keyboardModifier The keyboard modifier that was released.
*/
private keyUpEvent;
/**
* Sends the Click mouse event to the Standard Notes parent application.
*/
Expand Down
Loading
Loading