fix: correct comparison operator to assignment in OFT lzReceive dead …#33
Open
mefai-dev wants to merge 1 commit intostargate-protocol:mainfrom
Open
fix: correct comparison operator to assignment in OFT lzReceive dead …#33mefai-dev wants to merge 1 commit intostargate-protocol:mainfrom
mefai-dev wants to merge 1 commit intostargate-protocol:mainfrom
Conversation
…address guard The dead address guard on line 107 of OmnichainFungibleToken.sol uses the comparison operator (==) instead of the assignment operator (=), causing the toAddress reassignment to address(0xdEaD) to never take effect. When a cross-chain OFT transfer is received with toAddress == address(0x0), the intended behavior is to redirect tokens to the burn address (0xdEaD). Due to this bug, toAddress remains 0x0, causing _transfer or _mint to the zero address, which reverts in OpenZeppelin's ERC20 implementation. This permanently blocks the LayerZero nonce for that source chain path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address guard
The dead address guard on line 107 of OmnichainFungibleToken.sol uses the comparison operator (==) instead of the assignment operator (=), causing the toAddress reassignment to address(0xdEaD) to never take effect.
When a cross-chain OFT transfer is received with toAddress == address(0x0), the intended behavior is to redirect tokens to the burn address (0xdEaD). Due to this bug, toAddress remains 0x0, causing _transfer or _mint to the zero address, which reverts in OpenZeppelin's ERC20 implementation. This permanently blocks the LayerZero nonce for that source chain path.