Skip to content

fix: include fee in revolut trade id creation #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zahrun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: include fee in revolut trade id creation #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/parsers/trades/revolut/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ export default async function processData(importDetails: IImport): Promise<ITrad
console.log(`Not an exchange ${trade.Type}`);
continue;
}
const tradeToAdd: IPartialTrade = {};
tradeToAdd.date = createDateAsUTC(new Date(trade['Completed Date'])).getTime();
tradeToAdd.exchange = EXCHANGES.Revolut;
const tradeToAdd: IPartialTrade = {
date : createDateAsUTC(new Date(trade['Completed Date'])).getTime(),
exchange : EXCHANGES.Revolut,
};
const bought = trade.Description.substr(trade.Description.lastIndexOf(' ') + 1);
if (bought === trade.Currency) {
tradeToAdd.boughtCurrency = trade.Currency;
Expand All @@ -46,10 +47,10 @@ export default async function processData(importDetails: IImport): Promise<ITrad
console.log(`Error base currency \"${trade['Base currency']}\"`);
continue;
}
tradeToAdd.ID = createID(tradeToAdd);
tradeToAdd.exchangeID = tradeToAdd.ID;
tradeToAdd.transactionFeeCurrency = trade['Base currency'];
tradeToAdd.transactionFee = Math.round((parseFloat(trade['Fiat amount (inc. fees)'])-parseFloat(trade['Fiat amount']))*100)/100;
tradeToAdd.ID = createID(tradeToAdd);
tradeToAdd.exchangeID = tradeToAdd.ID;
internalFormat.push(tradeToAdd as ITrade);
}
return internalFormat;
Expand Down