Feature/ab#2123 add compass point to light barriers#110
Merged
Conversation
flonix8
requested review from
witchpou and
ztarbug
and removed request for
ztarbug
witchpou
requested changes
Mar 9, 2026
service/src/main/java/de/starwit/service/analytics/MetadataService.java
Outdated
Show resolved
Hide resolved
witchpou
requested changes
Mar 9, 2026
| if (!metadata.getName().equals(job.getName())) return false; | ||
| if (!metadata.getClassification().equals(job.getClassification())) return false; | ||
| if (metadata.getGeoReferenced() != job.getGeoReferenced()) return false; | ||
| if (!metadata.getCenterLatitude().equals(job.getCenterLatitude())) return false; |
Collaborator
There was a problem hiding this comment.
with not geo-referenced content, error occured:
[ERROR] 2026-03-09 15:26:03.105 [SimpleAsyncTaskExecutor-1] LineCrossingRunner - Error storing Linecrossing observation: e3f776a389c7313e8356fc20c4cf55d6 has crossed line (area=1, name=LS1) in direction in
java.lang.NullPointerException: Cannot invoke "java.math.BigDecimal.equals(Object)" because the return value of "de.starwit.persistence.analytics.entity.MetadataEntity.getCenterLatitude()" is null
at de.starwit.service.analytics.MetadataService.metadataMatchesJob(MetadataService.java:90
witchpou
approved these changes
Mar 12, 2026
witchpou
deleted the
feature/AB#2123-add-compass-point-to-light-barriers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds "direction" to observation jobs (which is used in light barriers in observatory-config).
Also a bug is fixed where updated job metadata would never be updated in the analytics database.
Motivation and Context
How has this been tested?
A production dump has been used to test migration and functionality.
Screenshots (if appropriate):
Types of changes
Checklist: