[6.x] Stop re-checking index existence on every Algolia write - #15090
Open
edalzell wants to merge 1 commit into
Open
[6.x] Stop re-checking index existence on every Algolia write#15090edalzell wants to merge 1 commit into
edalzell wants to merge 1 commit into
Conversation
`settingsInitialized` was only set inside the branch that runs when the index does not exist. Once an index had been created, the flag stayed false forever, so every call to client() re-ran exists() and spent an extra listIndices() API call before each write. On a 2,773 document reindex (chunk size 10, 278 jobs) this meant 280 listIndices() calls costing ~24.5s, roughly half of all the time the reindex spent talking to Algolia. Set the flag regardless of whether the index already existed, so the check happens at most once per index instance. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
edalzell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was debugging a search index update timeout issue and when profiling discovered that
settingsInitializedwas only set inside the branch that runs when the index does not exist. Once an index had been created, the flag stayed false forever, so every call to client() re-ran exists() and spent an extra listIndices() API call before each write.On a 2,773 document reindex (chunk size 10, 278 jobs) this meant 280 listIndices() calls costing ~24.5s, roughly half of all the time the reindex spent talking to Algolia.
Set the flag regardless of whether the index already existed, so the check happens at most once per index instance.