[6.x] Ensure fields into the first section of a tab instead of the last - #15091
Open
mynetx wants to merge 1 commit into
Open
[6.x] Ensure fields into the first section of a tab instead of the last#15091mynetx wants to merge 1 commit into
mynetx wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a blueprint tab has multiple sections, fields added at runtime via
ensureField()get appended to the last section. The most visible casualty is the Super User toggle: add a new section to the user blueprint and the toggle jumps into it, away from the other user details.Before the v4 tabs rewrite (#7746), ensured fields defaulted to the first section. This restores that behaviour: ensured fields that don't already exist in the blueprint now land at the end of the first section of the tab. Fields that already exist keep their position, and
ensureFieldPrepended()still puts them at the top.While in there, ensuring a field that lives inside an imported fieldset now writes the config override back to the section the import is actually in. Previously the override could end up as a duplicate import descriptor in a different section whenever the import wasn't in the fallback section.
Fixes #13644
🤖 Generated with Claude Code