Draft
Conversation
Sahel13
reviewed
Feb 6, 2026
Sahel13
reviewed
Feb 6, 2026
Co-authored-by: Sahel Iqbal <sahel13miqbal@proton.me>
Sahel13
requested changes
Feb 6, 2026
Contributor
Author
|
Converting to draft until we decide how to support an absent initial observation |
Closed
Contributor
Author
|
@AdrienCorenflos recommends having synchronize method that brings all factors to the same time (as currently they are always asynchronous). |
Contributor
Author
|
Updated after #191 to work with new convention of no initial observation. I think the factorial API is quite clean! It should be easy to extend to discrete and particle methods - although that can be different PR(s) |
Contributor
Author
|
Not sure why the Github Action with the tests keeps cancelling itself |
Contributor
Author
|
I'm now thinking it will be useful to split |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first attempt at a factorial API. I appreciate it's quite a lot of code added (and this is just to support Gaussian methods). Happy to break it up into multiple PRs if we think that's easier to grasp and there's a logical way to do so.
In terms of modifications to the existing
cuthbertcode I think they are minimal. I just had to change theinit_preparein Kalman so that it doesn't actually touch the observation parameters if the observationyis all nans. This is to avoid mismatching dimensions because in this factorial API the initial step is very different (acts globally across factors) to the subsequent steps (acts locally only on selected factors). (I think we'll also have to change this for the other methods too)If anything is unclear please shout and I can document better!