Merged
Conversation
Contributor
Author
|
Change of note: the adaptive resampling is now a decorator of the resampling function rather than a float input to particle filter: I think this is a LOT cleaner. |
Contributor
Author
|
Ideally the DPF trick if @DanWaxman would also be implemented as a decorator given it only acts on the output of a resampling |
Sahel13
reviewed
Feb 24, 2026
Add assertion to ensure number of sampled indices matches particles.
SamDuffield
reviewed
Feb 24, 2026
Contributor
SamDuffield
left a comment
SamDuffield
left a comment
There was a problem hiding this comment.
Liking this! Definitely good to have this in cuthbertlib and indeed is more extensible to other resampling schemes or decorators in the future
SamDuffield
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the signature of resampling functions in prevision of #202