Open
Conversation
epost
approved these changes
Sep 25, 2019
Member
epost
left a comment
epost
left a comment
There was a problem hiding this comment.
Looks good @lopeetall! 👍 Sorry about the summit-induced delay.
| using namespace std; | ||
|
|
||
| template<typename ppT> | ||
| void vk_to_json(tbcs_ppzksnark_verification_key<ppT> vk, string pathToFile) |
Member
There was a problem hiding this comment.
@lopeetall Maybe add a doc comment here to clarify that vk means 'verifying key'? Or perhaps we could even have the function name spell it out. And perhaps it would also be good to make it more explicit that pathToFile refers to a json output file that is going to be created.
| vk_data << "[\"" << IC_N.X << "\", \"" << IC_N.Y << "\"]"; | ||
| } | ||
|
|
||
| vk_data << "]" << endl; |
Member
There was a problem hiding this comment.
Suggested change
| vk_data << "]" << endl; | |
| vk_data << "]" << endl; |
^ indentation whoopsie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a utility to serialize verifying keys and proofs to JSON so that they can more easily be used in Remix or Truffle.