Optimize generic pooled SML indexed dispatch and benchmark#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors an existing cache-locality benchmark into a generic “10k actor” dispatch benchmark to compare several dispatch strategies, and applies small hot-loop optimizations to sml::utility::sm_pool batch processing to reduce wrapper overhead.
Changes:
- Refactors
benchmark/connection/tensor_cache_locality.cppinto a generic dispatch-overhead benchmark (direct, per-actor SML, pooled indexed SML, pooled indexed batch). - Optimizes
sm_pool::process_indexed_batchby reusing anindexed_eventwrapper inside the loop. - Avoids an extra wrapper function call in
sm_pool::process_event_batch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| include/boost/sml/utility/sm_pool.hpp | Reduces per-iteration overhead in indexed/batch dispatch by reusing wrapper objects and calling sm_.process_event directly in batch loops. |
| benchmark/connection/tensor_cache_locality.cpp | Replaces tensor/link-unlink-specific benchmark with a generic dispatch benchmark comparing multiple dispatch approaches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmark/connection/tensor_cache_locality.cppas a generic SML dispatch benchmark (no link/unlink-specific logic)sm_pool::process_indexed_batchto reuse a single indexed-event wrapper in the hot loopsm_pool::process_event_batchValidation
scripts/quality_gates.sh